Verify TLS chain of trust, warn user if it fails. #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd be curious to see an estimate of how many servers do and don't. I know my server is self-signed currently. |
|
Hey, it's been a while since I worked on this and I don't remember it well, but it's a feature I tend to worry about if missing from peer to peer projects. I'm afraid I'm not presently using electrum or bsv. I do think there are lots of great further improvements in addition to this one, to include self-signed certificates, such as exchanging public keys of peers, and pinning certificates. One can also get a free signature at letsencrypt.org . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out electrumx is configured to not ever verify certificates.
Some of the server certificates are actually configured with authorities and can be verified.
In these changes I attempted to default to verifying certificates, and provide a warning if it fails. It would be safer to mark the peers bad but I'm not sure there are that many hosts with certificates in the chain of trust.